proc_fill_cache(): kill pointless check
authorAl Viro <viro@zeniv.linux.org.uk>
Sat, 15 Jun 2013 06:26:35 +0000 (10:26 +0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Sat, 29 Jun 2013 08:57:16 +0000 (12:57 +0400)
we'd just checked that child->d_inode is non-NULL, for fuck sake!

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/proc/base.c

index 0016350ad95e13a646978f8d3f19fb1afa145424..306419c1968171fab55b384f72973ad6f86b6f06 100644 (file)
@@ -1710,10 +1710,8 @@ bool proc_fill_cache(struct file *file, struct dir_context *ctx,
        if (!child || IS_ERR(child) || !child->d_inode)
                goto end_instantiate;
        inode = child->d_inode;
-       if (inode) {
-               ino = inode->i_ino;
-               type = inode->i_mode >> 12;
-       }
+       ino = inode->i_ino;
+       type = inode->i_mode >> 12;
        dput(child);
 end_instantiate:
        if (!ino)