phy: fix return value check in armada375_usb_phy_probe()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Wed, 14 Jan 2015 01:10:00 +0000 (09:10 +0800)
committerKishon Vijay Abraham I <kishon@ti.com>
Wed, 21 Jan 2015 09:53:06 +0000 (15:23 +0530)
In case of error, the function devm_ioremap_resource() returns
ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
drivers/phy/phy-armada375-usb2.c

index ac7d99d01cb3774dd46c0bda06acef8ef2bc44e7..7c99ca256f059f79d4b288140da3feef5e0a67f8 100644 (file)
@@ -118,8 +118,8 @@ static int armada375_usb_phy_probe(struct platform_device *pdev)
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        usb_cluster_base = devm_ioremap_resource(&pdev->dev, res);
-       if (!usb_cluster_base)
-               return -ENOMEM;
+       if (IS_ERR(usb_cluster_base))
+               return PTR_ERR(usb_cluster_base);
 
        phy = devm_phy_create(dev, NULL, &armada375_usb_phy_ops);
        if (IS_ERR(phy)) {