Staging: media: Replace dev_err with pr_err to avoid null pointer derefrence
authorHaneen Mohammed <hamohammed.sa@gmail.com>
Fri, 6 Mar 2015 17:01:07 +0000 (20:01 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Mar 2015 23:54:41 +0000 (15:54 -0800)
This patch replace dev_err with pr_err, for pointer is derefrenced after comparing it to NULL.
This was found using the following coccinelle script:

@disable is_null@
identifier f;
expression E;
identifier fld;
statement S;
@@

+ if(E == NULL) S
f(...,E->fld,...);
-if(E == NULL) S;

@@
identifier f;
expression E;
identifier fld;
statement S;
@@

+ if(!E) S
f(...,E->fld,...);
-if(!E) S;

Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/media/lirc/lirc_zilog.c

index e16627ca488e654011a00e38fe84d5d36019c9ce..261e27d6b054c183c9886eb752fdee57111d7c42 100644 (file)
@@ -1341,8 +1341,7 @@ static int close(struct inode *node, struct file *filep)
        struct IR *ir = filep->private_data;
 
        if (ir == NULL) {
-               dev_err(ir->l.dev,
-                       "close: no private_data attached to the file!\n");
+               pr_err("ir: close: no private_data attached to the file!\n");
                return -ENODEV;
        }