ceph: reset bits on connection close
authorSage Weil <sage@newdream.net>
Fri, 26 Feb 2010 21:55:51 +0000 (13:55 -0800)
committerSage Weil <sage@newdream.net>
Mon, 1 Mar 2010 23:19:51 +0000 (15:19 -0800)
Clear LOSSYTX bit, so that if/when we reconnect, said reconnect
will retry on failure.

Clear _PENDING bits too, to avoid polluting subsequent
connection state.

Drop unused REGISTERED bit.

Signed-off-by: Sage Weil <sage@newdream.net>
fs/ceph/messenger.c
fs/ceph/messenger.h

index 0ddc2c75f6b407f4ddd7a4384308f301df211668..bf4590c77cf6698baedaed1d490f2cacebeffa80 100644 (file)
@@ -342,6 +342,9 @@ void ceph_con_close(struct ceph_connection *con)
        dout("con_close %p peer %s\n", con, pr_addr(&con->peer_addr.in_addr));
        set_bit(CLOSED, &con->state);  /* in case there's queued work */
        clear_bit(STANDBY, &con->state);  /* avoid connect_seq bump */
+       clear_bit(LOSSYTX, &con->state);  /* so we retry next connect */
+       clear_bit(KEEPALIVE_PENDING, &con->state);
+       clear_bit(WRITE_PENDING, &con->state);
        mutex_lock(&con->mutex);
        reset_connection(con);
        cancel_delayed_work(&con->work);
index c9735378be3ffdefff6940d6dfbe8aad07cd543a..4caaa5911110372510946678dc62b1ac181fcc38 100644 (file)
@@ -119,7 +119,6 @@ struct ceph_msg_pos {
                            * state with the peer. */
 #define CLOSED         10 /* we've closed the connection */
 #define SOCK_CLOSED    11 /* socket state changed to closed */
-#define REGISTERED      12 /* connection appears in con_tree */
 #define OPENING         13 /* open connection w/ (possibly new) peer */
 #define DEAD            14 /* dead, about to kfree */