usb: gadget: net2280: Fix superspeed dma_done()
authorMario Schuknecht <mario.schuknecht@dresearch-fe.de>
Sun, 16 Nov 2014 20:21:45 +0000 (21:21 +0100)
committerFelipe Balbi <balbi@ti.com>
Thu, 20 Nov 2014 19:51:25 +0000 (13:51 -0600)
Parameter three in function call dma_done() is incorrect.
Move use of variable 'tmp' after if-condition.

Signed-off-by: Mario Schuknecht <mario.schuknecht@dresearch-fe.de>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/udc/net2280.c

index c491794937966587860fefd6ea8645bbb62976fd..d6411e0a8e036c01fe86ded7206700e50e75d539 100644 (file)
@@ -1118,10 +1118,10 @@ static void scan_dma_completions(struct net2280_ep *ep)
                        break;
                } else if (!ep->is_in &&
                                (req->req.length % ep->ep.maxpacket) != 0) {
-                       tmp = readl(&ep->regs->ep_stat);
                        if (ep->dev->quirks & PLX_SUPERSPEED)
                                return dma_done(ep, req, tmp, 0);
 
+                       tmp = readl(&ep->regs->ep_stat);
                        /* AVOID TROUBLE HERE by not issuing short reads from
                         * your gadget driver.  That helps avoids errata 0121,
                         * 0122, and 0124; not all cases trigger the warning.