drm/radeon: check buffer relocation offset
authorLeo Liu <leo.liu@amd.com>
Mon, 28 Apr 2014 13:40:22 +0000 (09:40 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 7 Jun 2014 20:25:32 +0000 (13:25 -0700)
commit 695daf1a8e731a4b5b89de89a61f32a4d7ad7094 upstream.

Signed-off-by: Leo Liu <leo.liu@amd.com>
Signed-off-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/radeon/radeon_uvd.c

index 21d2d5280fc1de6004bae215d57ed4a967e5753d..5715429279fb8562f84f777248d65498bebf26b5 100644 (file)
@@ -449,6 +449,10 @@ static int radeon_uvd_cs_reloc(struct radeon_cs_parser *p,
        cmd = radeon_get_ib_value(p, p->idx) >> 1;
 
        if (cmd < 0x4) {
+               if (end <= start) {
+                       DRM_ERROR("invalid reloc offset %X!\n", offset);
+                       return -EINVAL;
+               }
                if ((end - start) < buf_sizes[cmd]) {
                        DRM_ERROR("buffer to small (%d / %d)!\n",
                                  (unsigned)(end - start), buf_sizes[cmd]);