ext3: get rid of the duplicate code on ext3_fill_super
authorZhao Hongjiang <zhaohongjiang@huawei.com>
Mon, 29 Oct 2012 07:28:07 +0000 (15:28 +0800)
committerJan Kara <jack@suse.cz>
Thu, 13 Dec 2012 15:33:24 +0000 (16:33 +0100)
Setting s_mount_opt to 0 is unnecessary because we use kzalloc() for sb
allocation. s_resuid and s_resgid are set again few lines below based on
values in on disk superblock.

Signed-off-by: Zhao Hongjiang <zhaohongjiang@huawei.com>
Signed-off-by: Jan Kara <jack@suse.cz>
fs/ext3/super.c

index 5366393528dfbd622120549729cf22a891026f44..6e50223b3299fcc8628115a6984bc6c9d6160f13 100644 (file)
@@ -1661,9 +1661,6 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)
                return -ENOMEM;
        }
        sb->s_fs_info = sbi;
-       sbi->s_mount_opt = 0;
-       sbi->s_resuid = make_kuid(&init_user_ns, EXT3_DEF_RESUID);
-       sbi->s_resgid = make_kgid(&init_user_ns, EXT3_DEF_RESGID);
        sbi->s_sb_block = sb_block;
 
        blocksize = sb_min_blocksize(sb, EXT3_MIN_BLOCK_SIZE);