regulator: rc5t583: Simplify rc5t583_set_voltage_time_sel implementation
authorAxel Lin <axel.lin@gmail.com>
Thu, 7 Jun 2012 08:38:09 +0000 (16:38 +0800)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Thu, 7 Jun 2012 23:29:48 +0000 (07:29 +0800)
For linear mappings, we can use below equation to get the voltage difference
between new_selector and old_selector:

abs(new_selector - old_selector) * rdev->desc->uV_step

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
drivers/regulator/rc5t583-regulator.c

index 1d34e64a1307ac3b1e6fd9edb0ad47395aee56ef..332eae897dab3665b38282c3256a9e2bac25f753 100644 (file)
@@ -70,18 +70,10 @@ static int rc5t583_set_voltage_time_sel(struct regulator_dev *rdev,
                unsigned int old_selector, unsigned int new_selector)
 {
        struct rc5t583_regulator *reg = rdev_get_drvdata(rdev);
-       int old_uV, new_uV;
-       old_uV = regulator_list_voltage_linear(rdev, old_selector);
 
-       if (old_uV < 0)
-               return old_uV;
-
-       new_uV = regulator_list_voltage_linear(rdev, new_selector);
-       if (new_uV < 0)
-               return new_uV;
-
-       return DIV_ROUND_UP(abs(old_uV - new_uV),
-                               reg->reg_info->change_uv_per_us);
+       return DIV_ROUND_UP(abs(new_selector - old_selector) *
+                           rdev->desc->uV_step,
+                           reg->reg_info->change_uv_per_us);
 }