pinctrl: rockchip: Simplify for loop iteration
authorAxel Lin <axel.lin@ingics.com>
Wed, 21 Aug 2013 02:28:50 +0000 (10:28 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 23 Aug 2013 06:56:32 +0000 (08:56 +0200)
Just return once a match found makes the code simpler and shorter.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-rockchip.c

index c22457de0048adb5e13c938ba62643dcbf432559..64ad0c0a1536450992d791f254cf07b755d9b18a 100644 (file)
@@ -167,18 +167,14 @@ static const inline struct rockchip_pin_group *pinctrl_name_to_group(
                                        const struct rockchip_pinctrl *info,
                                        const char *name)
 {
-       const struct rockchip_pin_group *grp = NULL;
        int i;
 
        for (i = 0; i < info->ngroups; i++) {
-               if (strcmp(info->groups[i].name, name))
-                       continue;
-
-               grp = &info->groups[i];
-               break;
+               if (!strcmp(info->groups[i].name, name))
+                       return &info->groups[i];
        }
 
-       return grp;
+       return NULL;
 }
 
 /*
@@ -204,17 +200,12 @@ static struct rockchip_pin_bank *bank_num_to_bank(
        struct rockchip_pin_bank *b = info->ctrl->pin_banks;
        int i;
 
-       for (i = 0; i < info->ctrl->nr_banks; i++) {
+       for (i = 0; i < info->ctrl->nr_banks; i++, b++) {
                if (b->bank_num == num)
-                       break;
-
-               b++;
+                       return b;
        }
 
-       if (b->bank_num != num)
-               return ERR_PTR(-EINVAL);
-
-       return b;
+       return ERR_PTR(-EINVAL);
 }
 
 /*