[SCSI] libfc: don't swap OX_ID and RX_ID when sending BA_RJT
authorJoe Eykholt <jeykholt@cisco.com>
Tue, 25 Aug 2009 21:04:03 +0000 (14:04 -0700)
committerJames Bottomley <James.Bottomley@suse.de>
Thu, 10 Sep 2009 17:08:03 +0000 (12:08 -0500)
I saw an lport debug message from the exchange manager saying:
"lport  70500: Received response for out of range oxid:ffff"

A trace showed this was a BA_RJT sent due to an incoming ABTS
which arrived on an unknown exchange.  So, the sender of the
BA_RJT was in error, but in this case, both the initiator and
responder were the same machine.

The OX_ID and RX_ID should not have been reversed in this case.

Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/libfc/fc_exch.c

index b51db15a3876b8a68a376672d30662c7ba949733..c1c15748220cb4be8f7e15f42aee5a8c3df9c9d1 100644 (file)
@@ -1017,8 +1017,8 @@ static void fc_exch_send_ba_rjt(struct fc_frame *rx_fp,
         */
        memcpy(fh->fh_s_id, rx_fh->fh_d_id, 3);
        memcpy(fh->fh_d_id, rx_fh->fh_s_id, 3);
-       fh->fh_ox_id = rx_fh->fh_rx_id;
-       fh->fh_rx_id = rx_fh->fh_ox_id;
+       fh->fh_ox_id = rx_fh->fh_ox_id;
+       fh->fh_rx_id = rx_fh->fh_rx_id;
        fh->fh_seq_cnt = rx_fh->fh_seq_cnt;
        fh->fh_r_ctl = FC_RCTL_BA_RJT;
        fh->fh_type = FC_TYPE_BLS;