cpufreq: Break out early when frequency equals target_freq
authorStratos Karafotis <stratosk@semaphore.gr>
Wed, 14 May 2014 18:05:52 +0000 (21:05 +0300)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 20 May 2014 12:02:09 +0000 (14:02 +0200)
Many drivers keep frequencies in frequency table in ascending
or descending order. When governor tries to change to policy->min
or policy->max respectively then the cpufreq_frequency_table_target
could return on first iteration. This will save some iteration cycles.

So, break out early when a frequency in cpufreq_frequency_table
equals to target one.

Testing this during kernel compilation using ondemand governor
with a frequency table in ascending order, the
cpufreq_frequency_table_target returned early on the first
iteration at about 30% of times called.

Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/freq_table.c

index 8e518c6893935135e0bfff4d7c7b8735bd0fefa1..1632981c4b25b7882008f25991c2071e94faf607 100644 (file)
@@ -137,9 +137,13 @@ int cpufreq_frequency_table_target(struct cpufreq_policy *policy,
                i = pos - table;
                if ((freq < policy->min) || (freq > policy->max))
                        continue;
+               if (freq == target_freq) {
+                       optimal.driver_data = i;
+                       break;
+               }
                switch (relation) {
                case CPUFREQ_RELATION_H:
-                       if (freq <= target_freq) {
+                       if (freq < target_freq) {
                                if (freq >= optimal.frequency) {
                                        optimal.frequency = freq;
                                        optimal.driver_data = i;
@@ -152,7 +156,7 @@ int cpufreq_frequency_table_target(struct cpufreq_policy *policy,
                        }
                        break;
                case CPUFREQ_RELATION_L:
-                       if (freq >= target_freq) {
+                       if (freq > target_freq) {
                                if (freq <= optimal.frequency) {
                                        optimal.frequency = freq;
                                        optimal.driver_data = i;