stmmac: Fix build warnings.
authorDavid S. Miller <davem@davemloft.net>
Tue, 31 Aug 2010 04:55:17 +0000 (21:55 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 31 Aug 2010 04:55:17 +0000 (21:55 -0700)
In file included from drivers/net/stmmac/stmmac_ethtool.c:30:
drivers/net/stmmac/stmmac.h:111: warning: 'struct platform_device' declared inside parameter list
drivers/net/stmmac/stmmac.h:111: warning: its scope is only this definition or declaration, which is probably not what you want
drivers/net/stmmac/stmmac_main.c: In function 'stmmac_dvr_probe':
drivers/net/stmmac/stmmac_main.c:1744: warning: cast from pointer to integer of different size
In file included from drivers/net/stmmac/stmmac_mdio.c:31:
drivers/net/stmmac/stmmac.h:111: warning: 'struct platform_device' declared inside parameter list
drivers/net/stmmac/stmmac.h:111: warning: its scope is only this definition or declaration, which is probably not what you want
drivers/net/stmmac/dwmac1000_core.c: In function 'dwmac1000_dump_regs':
drivers/net/stmmac/dwmac1000_core.c:56: warning: cast from pointer to integer of different size

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/stmmac/dwmac1000_core.c
drivers/net/stmmac/stmmac.h
drivers/net/stmmac/stmmac_main.c

index 8bbfc0f48deaab9423c7230ff4767457a6ff8487..f1f426146f403be79ed4f20832392bfb53215d88 100644 (file)
@@ -53,7 +53,7 @@ static void dwmac1000_core_init(void __iomem *ioaddr)
 static void dwmac1000_dump_regs(void __iomem *ioaddr)
 {
        int i;
-       pr_info("\tDWMAC1000 regs (base addr = 0x%8x)\n", (unsigned int)ioaddr);
+       pr_info("\tDWMAC1000 regs (base addr = 0x%p)\n", ioaddr);
 
        for (i = 0; i < 55; i++) {
                int offset = i * 4;
index cca53dbac3611cf96b710827370ced3c7f9c1ae0..d0ddab0d21c227c4a7b69c835acc542e89be054c 100644 (file)
@@ -21,6 +21,7 @@
 *******************************************************************************/
 
 #define DRV_MODULE_VERSION     "Apr_2010"
+#include <linux/platform_device.h>
 #include <linux/stmmac.h>
 
 #include "common.h"
index c59c1061252af28ecf3f01667355ed8f00d8b883..e3f002eba89a7f5f3eca8ded06f354fcf0413a75 100644 (file)
@@ -1742,8 +1742,8 @@ static int stmmac_dvr_probe(struct platform_device *pdev)
        priv->bsp_priv = plat_dat->bsp_priv;
 
        pr_info("\t%s - (dev. name: %s - id: %d, IRQ #%d\n"
-              "\tIO base addr: 0x%08x)\n", ndev->name, pdev->name,
-              pdev->id, ndev->irq, (unsigned int)addr);
+              "\tIO base addr: 0x%p)\n", ndev->name, pdev->name,
+              pdev->id, ndev->irq, addr);
 
        /* MDIO bus Registration */
        pr_debug("\tMDIO bus (id: %d)...", priv->bus_id);