Input: evdev - fix variable initialisation
authorHeiko Stuebner <heiko@sntech.de>
Wed, 1 Feb 2012 18:33:01 +0000 (10:33 -0800)
committerDima Zavin <dima@android.com>
Wed, 1 Feb 2012 18:57:42 +0000 (10:57 -0800)
Commit 509f87c5f564 (evdev - do not block waiting for an event if
fd
is nonblock) created a code path were it was possible to use retval
uninitialized.

This could lead to the xorg evdev input driver getting corrupt data
and refusing to work with log messages like
AUO-Pixcir touchscreen: Read error: Success
sg060_keys: Read error: Success
AUO-Pixcir touchscreen: Read error: Success
sg060_keys: Read error: Success
(for drivers auo-pixcir-ts and gpio-keys).

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
drivers/input/evdev.c

index d497c972e714352f121d766fdd7e673a5576cc2e..6288d7d84fa7e061d9ad3967e37782fbc4a17c24 100644 (file)
@@ -404,7 +404,7 @@ static ssize_t evdev_read(struct file *file, char __user *buffer,
        struct evdev_client *client = file->private_data;
        struct evdev *evdev = client->evdev;
        struct input_event event;
-       int retval;
+       int retval = 0;
 
        if (count < input_event_size())
                return -EINVAL;