USB: DWC3: Generate interrupt on each TRB as default option
authorPratyush Anand <pratyush.anand@st.com>
Mon, 21 May 2012 07:12:54 +0000 (12:42 +0530)
committerFelipe Balbi <balbi@ti.com>
Mon, 4 Jun 2012 15:17:04 +0000 (18:17 +0300)
Currently in case of isoc, interrupt is programmed after each
TRB_NUM/4 ie 8th TRB. A TRB is programmed against each submitted
request from gadget. If we do not want to limit the minimum number of
necessary request to be submitted from gadget then we must receive
interrupt on each TRB submission. There can be such situation with a
gadget working with ping-pong buffer.

If a gadget does not want to receive interrupt after each request
completion then it may set no_interrupt flag.

Signed-off-by: Pratyush Anand <pratyush.anand@st.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/dwc3/gadget.c

index a9fc7c4a5a2029427b32eb9a629b0a19abff32fb..be87e82b36c709b69092dd52f979f385f835e558 100644 (file)
@@ -766,8 +766,7 @@ static void dwc3_prepare_one_trb(struct dwc3_ep *dep,
        case USB_ENDPOINT_XFER_ISOC:
                trb->ctrl = DWC3_TRBCTL_ISOCHRONOUS_FIRST;
 
-               /* IOC every DWC3_TRB_NUM / 4 so we can refill */
-               if (!(cur_slot % (DWC3_TRB_NUM / 4)))
+               if (!req->request.no_interrupt)
                        trb->ctrl |= DWC3_TRB_CTRL_IOC;
                break;