HID: picolcd_core: Remove setting hdev->claimed before calling hid_hw_start()
authorAxel Lin <axel.lin@gmail.com>
Thu, 13 Sep 2012 22:15:36 +0000 (06:15 +0800)
committerJiri Kosina <jkosina@suse.cz>
Wed, 19 Sep 2012 11:57:03 +0000 (13:57 +0200)
Current implementation of hid_hw_start() allows connect_mask to be 0.
Setting hdev->claimed = HID_CLAIMED_INPUT before calling hid_hw_start() is not
necessary. Remove it.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-By: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-picolcd_core.c

index bd2a75185cb35cb5c81b047a8939b779bff902d7..86df26e58abac65f671601b70f15085faa4fdece 100644 (file)
@@ -565,11 +565,7 @@ static int picolcd_probe(struct hid_device *hdev,
                goto err_cleanup_data;
        }
 
-       /* We don't use hidinput but hid_hw_start() fails if nothing is
-        * claimed. So spoof claimed input. */
-       hdev->claimed = HID_CLAIMED_INPUT;
        error = hid_hw_start(hdev, 0);
-       hdev->claimed = 0;
        if (error) {
                hid_err(hdev, "hardware start failed\n");
                goto err_cleanup_data;