staging: sm7xxfb: cleanup on smtc_alloc_fb_info
authorJavier M. Mellid <jmunhoz@igalia.com>
Mon, 17 Sep 2012 14:12:49 +0000 (16:12 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Sep 2012 21:57:52 +0000 (14:57 -0700)
This patch improves code legibility after last changes.

Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/sm7xxfb/sm7xxfb.c

index f6ecac35d49582d0cea1d85fd6245fe838594dfd..5ad52b9204b0579e1d8583e68e6b4e0a0e6b0271 100644 (file)
@@ -679,7 +679,7 @@ static struct fb_ops smtcfb_ops = {
 };
 
 /*
- * alloc struct smtcfb_info and assign the default value
+ * alloc struct smtcfb_info and assign default values
  */
 static struct smtcfb_info *smtc_alloc_fb_info(struct pci_dev *pdev)
 {
@@ -692,18 +692,12 @@ static struct smtcfb_info *smtc_alloc_fb_info(struct pci_dev *pdev)
 
        sfb->pdev = pdev;
 
-       /* init sfb->fb with default value */
-
-       sfb->fb.flags = FBINFO_FLAG_DEFAULT;
-       sfb->fb.fbops = &smtcfb_ops;
-
-       sfb->fb.fix = smtcfb_fix;
-
-       sfb->fb.var = smtcfb_var;
-
-       sfb->fb.pseudo_palette  = sfb->colreg;
-
-       sfb->fb.par = sfb;
+       sfb->fb.flags          = FBINFO_FLAG_DEFAULT;
+       sfb->fb.fbops          = &smtcfb_ops;
+       sfb->fb.fix            = smtcfb_fix;
+       sfb->fb.var            = smtcfb_var;
+       sfb->fb.pseudo_palette = sfb->colreg;
+       sfb->fb.par            = sfb;
 
        return sfb;
 }