Disable failing wangle test
authorNicholas Ormrod <njormrod@fb.com>
Thu, 25 Sep 2014 00:02:47 +0000 (17:02 -0700)
committerAnton Likhtarov <alikhtarov@fb.com>
Fri, 26 Sep 2014 22:24:25 +0000 (15:24 -0700)
Summary:
Under moderate load, this part of the test would fail. When
there is resource contention, it is quite possible that the timeout will
be exceeded. A further reduction of the time spread will render this
test next to useless.

Moderate load can be as little as running all of folly's tests at once,
which is something that our testing infrastructure does quite
frequently.

fbconfig -r folly
fbmake runtests

Test Plan:
fbconfig -r folly && fbmake runtests

Reviewed By: hannesr@fb.com

Subscribers: sdwilsh, fugalh, njormrod

FB internal diff: D1576570

Tasks: 5225808

folly/wangle/test/FutureTest.cpp

index 1bf275337cd97ae936e5fb8787864658bc271326..1f0fad3c005317d3ac38cbe641c609a3cc3e054d 100644 (file)
@@ -727,16 +727,6 @@ TEST(Future, waitWithSemaphoreForTime) {
   p2.setValue(true);
   EXPECT_TRUE(t.isReady());
  }
- {
-  Promise<int> p;
-  Future<int> f = p.getFuture();
-  auto begin = std::chrono::system_clock::now();
-  auto t = waitWithSemaphore(std::move(f),
-    std::chrono::milliseconds(1));
-  auto end = std::chrono::system_clock::now();
-  EXPECT_TRUE( end - begin < std::chrono::milliseconds(5));
-  EXPECT_FALSE(t.isReady());
- }
  {
   auto t = waitWithSemaphore(makeFuture(),
     std::chrono::milliseconds(1));