perf/x86: Micro-optimize nhmex_rbox_get_constraint()
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Thu, 19 Jun 2014 13:15:31 +0000 (15:15 +0200)
committerIngo Molnar <mingo@kernel.org>
Sat, 5 Jul 2014 09:21:52 +0000 (11:21 +0200)
Flipping the LSB doesn't require four lines of code. This shaves a few
bytes of the generated code, including a branch.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1403183731-15402-1-git-send-email-linux@rasmusvillemoes.dk
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/cpu/perf_event_intel_uncore.c

index 65bbbea38b9c9c0f7246a3c4fee4176dd529647b..e009f3cedf89ba8c31cf369e2501b917559588fd 100644 (file)
@@ -2946,10 +2946,7 @@ again:
                 * extra registers. If we failed to take an extra
                 * register, try the alternative.
                 */
-               if (idx % 2)
-                       idx--;
-               else
-                       idx++;
+               idx ^= 1;
                if (idx != reg1->idx % 6) {
                        if (idx == 2)
                                config1 >>= 8;