xhci: Kill streams URBs when the host dies.
authorSarah Sharp <sarah.a.sharp@linux.intel.com>
Fri, 21 Feb 2014 22:29:02 +0000 (14:29 -0800)
committerSarah Sharp <sarah.a.sharp@linux.intel.com>
Tue, 4 Mar 2014 23:40:45 +0000 (15:40 -0800)
If the host controller stops responding to commands, we need to kill all
the URBs that were queued to all endpoints.  The current code would only
kill URBs that had been queued to the endpoint rings.  ep->ring is set
to NULL if streams has been enabled for the endpoint, which means URBs
submitted with a non-zero stream_id would never get killed.  Fix this.

Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
drivers/usb/host/xhci-ring.c

index 58cbc06ecdf9eb4eb4820b5ef5c37fd1ff053ad5..5f926bea5ab1d87a54054ad68555ea31bd62cb63 100644 (file)
@@ -922,13 +922,27 @@ static void xhci_kill_endpoint_urbs(struct xhci_hcd *xhci,
        struct xhci_ring *ring;
 
        ep = &xhci->devs[slot_id]->eps[ep_index];
-       ring = ep->ring;
-       if (!ring)
-               return;
-       xhci_dbg_trace(xhci, trace_xhci_dbg_cancel_urb,
-                       "Killing URBs for slot ID %u, ep index %u",
-                       slot_id, ep_index);
-       xhci_kill_ring_urbs(xhci, ring);
+       if ((ep->ep_state & EP_HAS_STREAMS) ||
+                       (ep->ep_state & EP_GETTING_NO_STREAMS)) {
+               int stream_id;
+
+               for (stream_id = 0; stream_id < ep->stream_info->num_streams;
+                               stream_id++) {
+                       xhci_dbg_trace(xhci, trace_xhci_dbg_cancel_urb,
+                                       "Killing URBs for slot ID %u, ep index %u, stream %u",
+                                       slot_id, ep_index, stream_id + 1);
+                       xhci_kill_ring_urbs(xhci,
+                                       ep->stream_info->stream_rings[stream_id]);
+               }
+       } else {
+               ring = ep->ring;
+               if (!ring)
+                       return;
+               xhci_dbg_trace(xhci, trace_xhci_dbg_cancel_urb,
+                               "Killing URBs for slot ID %u, ep index %u",
+                               slot_id, ep_index);
+               xhci_kill_ring_urbs(xhci, ring);
+       }
        while (!list_empty(&ep->cancelled_td_list)) {
                cur_td = list_first_entry(&ep->cancelled_td_list,
                                struct xhci_td, cancelled_td_list);