gigaset: fix format string typo in CAPI dial command
authorTilman Schmidt <tilman@imap.cc>
Sun, 25 Oct 2009 09:29:47 +0000 (09:29 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 29 Oct 2009 08:37:08 +0000 (01:37 -0700)
A missing dot lead to garbage characters being included in the
dial command generated from a CAPI CONNECT_REQ message, which
interestingly enough worked anyway, illustrating the resilience
of the device.

Impact: bugfix
Signed-off-by: Tilman Schmidt <tilman@imap.cc>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/gigaset/capi.c

index ac0a2da1eef6160a6e66d3ad67446607e3850b30..d1afac2bf65077bf5cec89999aa51a16978c25ff 100644 (file)
@@ -1254,7 +1254,7 @@ static void do_connect_req(struct gigaset_capi_ctr *iif,
        commands[AT_DIAL] = kmalloc(l+3, GFP_KERNEL);
        if (!commands[AT_DIAL])
                goto oom;
-       snprintf(commands[AT_DIAL], l+3, "D%*s\r", l, pp);
+       snprintf(commands[AT_DIAL], l+3, "D%.*s\r", l, pp);
 
        /* encode parameter: Calling party number */
        pp = cmsg->CallingPartyNumber;