staging: comedi: adv_pci1723: remove private data 'da_range'
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Fri, 21 Nov 2014 21:22:28 +0000 (14:22 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Nov 2014 23:39:59 +0000 (15:39 -0800)
This member of the private data is initialized to 0 by pci1723_reset()
and is not used any where else in the driver. Remove it.

Use the register map defines to set the range for each output channel.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/adv_pci1723.c

index 51349893fb95a05ffcb303211ec18bd9ce629e91..87f78367fe95469f426a8364d06b013ae1caa9e3 100644 (file)
@@ -86,7 +86,6 @@ TODO:
 #define PCI1723_VREF_POS10V            (3 << 0)
 
 struct pci1723_private {
-       unsigned char da_range[8];      /* D/A output range for each channel */
        unsigned short ao_data[8];      /* data output buffer */
 };
 
@@ -105,8 +104,7 @@ static int pci1723_reset(struct comedi_device *dev)
                devpriv->ao_data[i] = 0x8000;
                outw(devpriv->ao_data[i], dev->iobase + PCI1723_AO_REG(i));
                /* set all ranges to +/- 10V */
-               devpriv->da_range[i] = 0;
-               outw(((devpriv->da_range[i] << 4) | i),
+               outw(PCI1723_CTRL_RANGE(0) | PCI1723_CTRL_CHAN(i),
                     PCI1723_CTRL_REG);
        }