netfilter: qtaguid: fix bad-arg handling when tagging socket

When processing args passed to the procfs ctrl, if the tag was
invalid it would exit without releasing the spin_lock...
Bye bye scheduling.

Signed-off-by: JP Abgrall <jpa@google.com>
Change-Id: Ic1480ae9d37bba687586094cf6d0274db9c5b28a

diff --git a/net/netfilter/xt_qtaguid.c b/net/netfilter/xt_qtaguid.c
index 3b5ab3ff061521c3edddff01ceea5e148f24c5b8..3cacec07fbf722adcb9870fee0bcb2b61fbcb786 100644 (file)
--- a/net/netfilter/xt_qtaguid.c
+++ b/net/netfilter/xt_qtaguid.c
@@ -1065,7 +1065,7 @@ static int qtaguid_ctrl_parse(const char *input, int count)
        goto ok;
 
 err_unlock:
-       if (!sock_tag_entry)
+       if (sock_tag_entry)
                spin_unlock_irqrestore(&sock_tag_list_lock, flags);
 err:
 ok: