Drop support for GCC < 4.8 in folly/test/FBStringTest.cpp
authorYedidya Feldblum <yfeldblum@fb.com>
Tue, 8 Sep 2015 22:24:42 +0000 (15:24 -0700)
committerfacebook-github-bot-1 <folly-bot@fb.com>
Tue, 8 Sep 2015 23:20:18 +0000 (16:20 -0700)
Summary: [Folly] Drop support for GCC < 4.8 in folly/test/FBStringTest.cpp.

Can't stay indefinitely backcompat with older compilers.

Reviewed By: @tudor

Differential Revision: D2422425

folly/test/FBStringTest.cpp

index d202d444e1e9768c1e1b1271fbab395af664b155..315b3e4acd9c299bcf2b5b0ff82ef8801ce81977 100644 (file)
@@ -1291,15 +1291,12 @@ TEST(FBString, testFrontBack) {
 
 TEST(FBString, noexcept) {
   EXPECT_TRUE(noexcept(fbstring()));
-  // std::move is not marked noexcept in gcc 4.6, sigh
-#if __GNUC_PREREQ(4, 7)
   fbstring x;
   EXPECT_FALSE(noexcept(fbstring(x)));
   EXPECT_TRUE(noexcept(fbstring(std::move(x))));
   fbstring y;
   EXPECT_FALSE(noexcept(y = x));
   EXPECT_TRUE(noexcept(y = std::move(x)));
-#endif
 }
 
 TEST(FBString, iomanip) {