usb: chipidea: otg initialization is only needed when the gadget is supported
authorPeter Chen <peter.chen@freescale.com>
Mon, 22 Sep 2014 00:14:16 +0000 (08:14 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 Sep 2014 04:32:31 +0000 (21:32 -0700)
We have only needed to enable otg initialization when both of
below conditions are satisfied:

- The controller is otg capable
- The gadget function is enabled

If the controller is otg capable, but is host-only configuration, we do
not need to access register otgsc and do any otg operations (eg, create
otg workqueue).

Signed-off-by: Peter Chen <peter.chen@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/chipidea/core.c

index 41d45a16dd3085402769707b901d13e1f3f28cf1..7cb74c4f0e92eb7df7f243d17b58ac9d8ca2a810 100644 (file)
@@ -662,7 +662,7 @@ static int ci_hdrc_probe(struct platform_device *pdev)
                goto deinit_phy;
        }
 
-       if (ci->is_otg) {
+       if (ci->is_otg && ci->roles[CI_ROLE_GADGET]) {
                /* Disable and clear all OTG irq */
                hw_write_otgsc(ci, OTGSC_INT_EN_BITS | OTGSC_INT_STATUS_BITS,
                                                        OTGSC_INT_STATUS_BITS);