Move lengthy conditional down 1 level per review comment.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@40878 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Target/X86/X86Subtarget.h b/lib/Target/X86/X86Subtarget.h
index 6240dc2715a8886823977c0e8320f8dae2eef4c8..772f1431c920a1ac1c131e9d49760df81d59444c 100644 (file)
--- a/lib/Target/X86/X86Subtarget.h
+++ b/lib/Target/X86/X86Subtarget.h
@@ -143,6 +143,11 @@ public:
                                          TargetType == isCygwin); }
   bool isTargetCygwin() const { return TargetType == isCygwin; }
 
+  std::string getDataLayout() const { return
+    is64Bit() ? std::string("e-p:64:64-f64:32:64-i64:32:64-f80:128:128") :
+    isTargetDarwin() ? std::string("e-p:32:32-f64:32:64-i64:32:64-f80:128:128") :
+    std::string("e-p:32:32-f64:32:64-i64:32:64-f80:32:32"); }
+
   bool isPICStyleSet() const { return PICStyle != PICStyle::None; }
   bool isPICStyleGOT() const { return PICStyle == PICStyle::GOT; }
   bool isPICStyleStub() const { return PICStyle == PICStyle::Stub; }

diff --git a/lib/Target/X86/X86TargetMachine.cpp b/lib/Target/X86/X86TargetMachine.cpp
index c754a1d9da41d43120ed0402c98e3c6b9d767efc..f87640f224bf85c852175edf2a49b05ef12186a0 100644 (file)
--- a/lib/Target/X86/X86TargetMachine.cpp
+++ b/lib/Target/X86/X86TargetMachine.cpp
@@ -114,11 +114,7 @@ X86_64TargetMachine::X86_64TargetMachine(const Module &M, const std::string &FS)
 X86TargetMachine::X86TargetMachine(const Module &M, const std::string &FS,
                                    bool is64Bit)
   : Subtarget(M, FS, is64Bit),
-    DataLayout(Subtarget.is64Bit() ?
-               std::string("e-p:64:64-f64:32:64-i64:32:64-f80:128:128") :
-                 Subtarget.isTargetDarwin() ?
-                 std::string("e-p:32:32-f64:32:64-i64:32:64-f80:128:128") :
-                 std::string("e-p:32:32-f64:32:64-i64:32:64-f80:32:32")),
+    DataLayout(Subtarget.getDataLayout()),
     FrameInfo(TargetFrameInfo::StackGrowsDown,
               Subtarget.getStackAlignment(), Subtarget.is64Bit() ? -8 : -4),
     InstrInfo(*this), JITInfo(*this), TLInfo(*this) {