[SCSI] libfcoe: FIP link keep-alive should continue while logged off
authorJoe Eykholt <jeykholt@cisco.com>
Fri, 11 Jun 2010 23:43:33 +0000 (16:43 -0700)
committerJames Bottomley <James.Bottomley@suse.de>
Tue, 27 Jul 2010 17:01:43 +0000 (12:01 -0500)
A check in fcoe_ctlr_send_keep_alive() returns if there's no
port_id for the local port.  This could miss a keep alive if
we just did a host reset and have logged off and will log back in.

Return only if we are doing the port keep alive, in which case
we need to be logged in.

Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/fcoe/libfcoe.c

index 50aaa4bcfc5062cd66301f660f469dd131fd0359..cc5e8864b8050fbc63bec8ebb0265b9fbc3f6c5a 100644 (file)
@@ -343,7 +343,7 @@ static void fcoe_ctlr_send_keep_alive(struct fcoe_ctlr *fip,
 
        fcf = fip->sel_fcf;
        lp = fip->lp;
-       if (!fcf || !lp->port_id)
+       if (!fcf || (ports && !lp->port_id))
                return;
 
        len = sizeof(*kal) + ports * sizeof(*vn);