Add a FIXME.
authorRafael Espindola <rafael.espindola@gmail.com>
Thu, 5 Feb 2015 14:57:47 +0000 (14:57 +0000)
committerRafael Espindola <rafael.espindola@gmail.com>
Thu, 5 Feb 2015 14:57:47 +0000 (14:57 +0000)
Thanks to Eric for the suggestion.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@228300 91177308-0d34-0410-b5e6-96231b3b80d8

lib/CodeGen/TargetLoweringObjectFileImpl.cpp

index 396d9e4fbfabc3add855f196523f9404603e670f..35860fa13375b8ad903c48ee15a8535feae8f6bc 100644 (file)
@@ -181,6 +181,9 @@ getELFSectionFlags(SectionKind K, bool InCOMDAT) {
   if (K.isThreadLocal())
     Flags |= ELF::SHF_TLS;
 
+  // FIXME: There is nothing in ELF preventing an SHF_MERGE from being
+  // in a comdat. We just avoid it for now because we don't print
+  // those .sections correctly.
   if (!InCOMDAT && (K.isMergeableCString() || K.isMergeableConst()))
     Flags |= ELF::SHF_MERGE;