[media] omap3isp: video: Set the buffer bytesused field at completion time
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Fri, 3 Jan 2014 01:15:07 +0000 (22:15 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Sun, 25 May 2014 14:12:30 +0000 (11:12 -0300)
The v4l buffer bytesused field is a value that will be returned to
userspace when the buffer gets dequeued. As such it doesn't need to be
set early at buffer queue time. Move the assignment to buffer completion
in the omap3isp_video_buffer_next() function to prepare for the video
buffers queue refactoring.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/media/platform/omap3isp/ispvideo.c

index 85b4036ba5e43296ce647c4f857e8484b430846c..e0f594f34becb79fab7bb9e4daea897a90940e0b 100644 (file)
@@ -431,7 +431,6 @@ static int isp_video_buffer_prepare(struct isp_video_buffer *buf)
                return -EINVAL;
        }
 
-       buf->vbuf.bytesused = vfh->format.fmt.pix.sizeimage;
        buffer->isp_addr = addr;
        return 0;
 }
@@ -514,6 +513,8 @@ struct isp_buffer *omap3isp_video_buffer_next(struct isp_video *video)
 {
        struct isp_pipeline *pipe = to_isp_pipeline(&video->video.entity);
        struct isp_video_queue *queue = video->queue;
+       struct isp_video_fh *vfh =
+               container_of(queue, struct isp_video_fh, queue);
        enum isp_pipeline_state state;
        struct isp_video_buffer *buf;
        unsigned long flags;
@@ -530,6 +531,8 @@ struct isp_buffer *omap3isp_video_buffer_next(struct isp_video *video)
        list_del(&buf->irqlist);
        spin_unlock_irqrestore(&queue->irqlock, flags);
 
+       buf->vbuf.bytesused = vfh->format.fmt.pix.sizeimage;
+
        ktime_get_ts(&ts);
        buf->vbuf.timestamp.tv_sec = ts.tv_sec;
        buf->vbuf.timestamp.tv_usec = ts.tv_nsec / NSEC_PER_USEC;