HID: wacom: Set default device name to value from wacom->features
authorJason Gerecke <killertofu@gmail.com>
Tue, 14 Jul 2015 01:03:45 +0000 (18:03 -0700)
committerJiri Kosina <jkosina@suse.com>
Fri, 17 Jul 2015 09:25:20 +0000 (11:25 +0200)
Allocated input devices should not use the 'pen_name' by default since
we do not know at that point in time if that is an appropriate choice
of name. Instead, use the (tool-agnostic) name that is stored in the
device's 'wacom_features' structure. This also has the nice side-effect
of requring us to be explicit about the naming of the pen device, as
we already are for touch and pad devices.

Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/wacom_sys.c

index 3512d833cc24d60a7b4d235bd040e4d6f131eb67..2a221630d8dccfcc9f2691d2f7e27607ce39b005 100644 (file)
@@ -1130,7 +1130,7 @@ static struct input_dev *wacom_allocate_input(struct wacom *wacom)
        if (!input_dev)
                return NULL;
 
-       input_dev->name = wacom_wac->pen_name;
+       input_dev->name = wacom_wac->features.name;
        input_dev->phys = hdev->phys;
        input_dev->dev.parent = &hdev->dev;
        input_dev->open = wacom_open;
@@ -1183,6 +1183,7 @@ static int wacom_allocate_inputs(struct wacom *wacom)
                return -ENOMEM;
        }
 
+       wacom_wac->pen_input->name = wacom_wac->pen_name;
        wacom_wac->touch_input->name = wacom_wac->touch_name;
        wacom_wac->pad_input->name = wacom_wac->pad_name;