S2io: two branches the same in wait_for_cmd_complete()
authorRam Vepa <ram.vepa@neterion.com>
Tue, 19 Jan 2010 20:36:20 +0000 (12:36 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 19 Jan 2010 20:36:20 +0000 (12:36 -0800)
Fix check to verify if a register bit is set. We have not hit this bug because
wait_for_cmd_complete() is always called with S2IO_BIT_RESET.
Reported by Roel Kluin <roel.kluin@gmail.com>.

Signed-off-by: Ram Vepa <ram.vepa@neterion.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/s2io.c

index cc4218667cbad22db8ac13c6e83729caec0dbebf..3c4836d0898f310403f9d44e714793a127514df0 100644 (file)
@@ -3421,7 +3421,7 @@ static int wait_for_cmd_complete(void __iomem *addr, u64 busy_bit,
                                break;
                        }
                } else {
-                       if (!(val64 & busy_bit)) {
+                       if (val64 & busy_bit) {
                                ret = SUCCESS;
                                break;
                        }