usb: renesas_usbhs: tidyup usbhs_for_each_dfifo macro
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tue, 14 Apr 2015 04:10:04 +0000 (04:10 +0000)
committerFelipe Balbi <balbi@ti.com>
Mon, 27 Apr 2015 20:48:33 +0000 (15:48 -0500)
Current usbhs_for_each_dfifo macro will read out-of-array's
memory after last loop operation.
It was not good C language operation, and the binary which was
compiled by (at least) gcc 4.8.1 is broken.

This patch is based on
925403f425a4a9c503f2fc295652647b1eb10d82
(usb: renesas_usbhs: tidyup original usbhsx_for_each_xxx macro)

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/renesas_usbhs/fifo.h

index 04d3f8abad9e5fcb59b71219496ee7a2122a7509..c7d9b86d51bf84eb30215724ade608649b24fb31 100644 (file)
@@ -44,10 +44,11 @@ struct usbhs_fifo_info {
        struct usbhs_fifo dfifo[USBHS_MAX_NUM_DFIFO];
 };
 #define usbhsf_get_dnfifo(p, n)        (&((p)->fifo_info.dfifo[n]))
-#define usbhs_for_each_dfifo(priv, dfifo, i)                           \
-       for ((i) = 0, dfifo = usbhsf_get_dnfifo(priv, (i));             \
-            ((i) < USBHS_MAX_NUM_DFIFO);                               \
-            (i)++, dfifo = usbhsf_get_dnfifo(priv, (i)))
+#define usbhs_for_each_dfifo(priv, dfifo, i)                   \
+       for ((i) = 0;                                           \
+            ((i) < USBHS_MAX_NUM_DFIFO) &&                     \
+                    ((dfifo) = usbhsf_get_dnfifo(priv, (i)));  \
+            (i)++)
 
 struct usbhs_pkt_handle;
 struct usbhs_pkt {