serial: 8250_dma: call serial8250_tx_dma unconditionally
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 6 Nov 2014 11:28:16 +0000 (13:28 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 6 Nov 2014 23:01:03 +0000 (15:01 -0800)
Since we have the same check inside the function we may drop it away in
__dma_tx_complete().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_dma.c

index 258430b72039eec482f64a394f6dfb2dd92ca34f..b16f9b169202abbc626ca3454b3950227504853f 100644 (file)
@@ -21,6 +21,7 @@ static void __dma_tx_complete(void *param)
        struct uart_8250_dma    *dma = p->dma;
        struct circ_buf         *xmit = &p->port.state->xmit;
        unsigned long   flags;
+       int             ret;
 
        dma_sync_single_for_cpu(dma->txchan->device->dev, dma->tx_addr,
                                UART_XMIT_SIZE, DMA_TO_DEVICE);
@@ -36,15 +37,11 @@ static void __dma_tx_complete(void *param)
        if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS)
                uart_write_wakeup(&p->port);
 
-       if (!uart_circ_empty(xmit) && !uart_tx_stopped(&p->port)) {
-               int ret;
-
-               ret = serial8250_tx_dma(p);
-               if (ret) {
-                       dma->tx_err = 1;
-                       p->ier |= UART_IER_THRI;
-                       serial_port_out(&p->port, UART_IER, p->ier);
-               }
+       ret = serial8250_tx_dma(p);
+       if (ret) {
+               dma->tx_err = 1;
+               p->ier |= UART_IER_THRI;
+               serial_port_out(&p->port, UART_IER, p->ier);
        }
 
        spin_unlock_irqrestore(&p->port.lock, flags);