staging: comedi: pass subdevice to comedi_buf_memcpy_from()
authorIan Abbott <abbotti@mev.co.uk>
Tue, 6 May 2014 12:12:02 +0000 (13:12 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 May 2014 12:25:48 +0000 (21:25 +0900)
Change the parameters of `comedi_buf_memcpy_from()` to pass a pointer to
the comedi subdevice instead of a pointer to the "async" structure
belonging to the subdevice.

The main aim at the moment is to replace all the `struct comedi_async *`
parameters with `struct comedi_subdevice *` parameters in the comedi
driver API.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/comedi_buf.c
drivers/staging/comedi/comedidev.h
drivers/staging/comedi/drivers/comedi_fc.c

index de850f3fd49d26ccb52aa5e3aa18056fc121676d..199ebb48974c3d9d5f0994d44279455e17423729 100644 (file)
@@ -472,10 +472,11 @@ void comedi_buf_memcpy_to(struct comedi_subdevice *s, unsigned int offset,
 }
 EXPORT_SYMBOL_GPL(comedi_buf_memcpy_to);
 
-void comedi_buf_memcpy_from(struct comedi_async *async, unsigned int offset,
+void comedi_buf_memcpy_from(struct comedi_subdevice *s, unsigned int offset,
                            void *dest, unsigned int nbytes)
 {
        void *src;
+       struct comedi_async *async = s->async;
        unsigned int read_ptr = async->buf_read_ptr + offset;
 
        if (read_ptr >= async->prealloc_bufsz)
index 221db717ebc4e2be82335d8312b0e5a523776064..0a68006e2c21757eb636ddf4f270e2eb3bf2d94f 100644 (file)
@@ -348,7 +348,7 @@ int comedi_buf_get(struct comedi_subdevice *s, unsigned short *x);
 
 void comedi_buf_memcpy_to(struct comedi_subdevice *s, unsigned int offset,
                          const void *source, unsigned int num_bytes);
-void comedi_buf_memcpy_from(struct comedi_async *async, unsigned int offset,
+void comedi_buf_memcpy_from(struct comedi_subdevice *s, unsigned int offset,
                            void *destination, unsigned int num_bytes);
 
 /* drivers.c - general comedi driver functions */
index 81749a778de015f265b43ccd8cfc3b38dc14aa35..5eff9d1cd072db06dfe0e08ecf8a3c51ca63f422 100644 (file)
@@ -92,7 +92,7 @@ unsigned int cfc_read_array_from_buffer(struct comedi_subdevice *s,
                return 0;
 
        num_bytes = comedi_buf_read_alloc(async, num_bytes);
-       comedi_buf_memcpy_from(async, 0, data, num_bytes);
+       comedi_buf_memcpy_from(s, 0, data, num_bytes);
        comedi_buf_read_free(async, num_bytes);
        cfc_inc_scan_progress(s, num_bytes);
        async->events |= COMEDI_CB_BLOCK;