drivers: staging: iio: accel: Removed unnecessary variable
authorTina Johnson <tinajohnson.1234@gmail.com>
Mon, 9 Mar 2015 10:41:16 +0000 (16:11 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 9 Mar 2015 12:39:10 +0000 (13:39 +0100)
Variable len is used only to store the return value. Hence len is
removed and the return statement modified. Coccinelle was used to
detect such removable variables:

@rule1@
identifier ret;
expression e;
@@

-ret =
+return
           e;
-return ret;

Signed-off-by: Tina Johnson <tinajohnson.1234@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/iio/accel/sca3000_core.c

index 31fb2182c198267caff8af6554767d37146c4072..b614f272b5f4b1b40071d4ea5e11678453a1f431 100644 (file)
@@ -870,7 +870,7 @@ static ssize_t sca3000_query_free_fall_mode(struct device *dev,
                                            struct device_attribute *attr,
                                            char *buf)
 {
-       int ret, len;
+       int ret;
        struct iio_dev *indio_dev = dev_to_iio_dev(dev);
        struct sca3000_state *st = iio_priv(indio_dev);
        int val;
@@ -881,9 +881,7 @@ static ssize_t sca3000_query_free_fall_mode(struct device *dev,
        mutex_unlock(&st->lock);
        if (ret < 0)
                return ret;
-       len = sprintf(buf, "%d\n",
-                     !!(val & SCA3000_FREE_FALL_DETECT));
-       return len;
+       return sprintf(buf, "%d\n", !!(val & SCA3000_FREE_FALL_DETECT));
 }
 
 /**