[SCSI] ipr: qc_fill_rtf() method should not store alternate status register
authorSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Tue, 21 May 2013 19:24:22 +0000 (23:24 +0400)
committerJames Bottomley <JBottomley@Parallels.com>
Wed, 26 Jun 2013 18:11:30 +0000 (11:11 -0700)
The 'ctl' field of  the 'struct ata_taskfile' is not really dual purpose, i.e.
it is not intended  for storing the alternate status register (which is mapped
at the same address in the legacy IDE controllers) in the qc_fill_rtf() method.
No other 'libata' driver except 'drivers/scsi/ipr.c' stores the alternate status
register's value in the 'ctl' field of 'qc->result_tf', hence this driver should
not do this as well...

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/ipr.c

index a87767f73913ddb0b329db0b2d7c40db2fed319b..0d431769f6631a084b0293ac1c4ad18f296a7d92 100644 (file)
@@ -6662,7 +6662,6 @@ static bool ipr_qc_fill_rtf(struct ata_queued_cmd *qc)
        tf->hob_lbal = g->hob_lbal;
        tf->hob_lbam = g->hob_lbam;
        tf->hob_lbah = g->hob_lbah;
-       tf->ctl = g->alt_status;
 
        return true;
 }