RegionInfo: Do not crash if unreachable block is found
authorTobias Grosser <grosser@fim.uni-passau.de>
Fri, 3 May 2013 15:48:34 +0000 (15:48 +0000)
committerTobias Grosser <grosser@fim.uni-passau.de>
Fri, 3 May 2013 15:48:34 +0000 (15:48 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181025 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Analysis/RegionInfo.cpp
test/Analysis/RegionInfo/unreachable_bb.ll [new file with mode: 0644]

index 81ef6505e611cabecdb716b08150afc465eccce3..857702570f2f8bd8ee55f1189e35c3a6397dab1e 100644 (file)
@@ -114,7 +114,8 @@ void Region::replaceExitRecursive(BasicBlock *NewExit) {
 bool Region::contains(const BasicBlock *B) const {
   BasicBlock *BB = const_cast<BasicBlock*>(B);
 
-  assert(DT->getNode(BB) && "BB not part of the dominance tree");
+  if (!DT->getNode(BB))
+    return false;
 
   BasicBlock *entry = getEntry(), *exit = getExit();
 
diff --git a/test/Analysis/RegionInfo/unreachable_bb.ll b/test/Analysis/RegionInfo/unreachable_bb.ll
new file mode 100644 (file)
index 0000000..626ccbe
--- /dev/null
@@ -0,0 +1,29 @@
+; RUN: opt -regions -analyze < %s | FileCheck %s
+
+; We should not crash if there are some bbs that are not reachable.
+define void @f() {
+entry:
+  br label %for.pre
+
+notintree:                                        ; No predecessors!
+  br label %ret
+
+for.pre:                                          ; preds = %entry
+  br label %for
+
+for:                                              ; preds = %for.inc, %for.pre
+  %indvar = phi i64 [ 0, %for.pre ], [ %indvar.next, %for.inc ]
+  %exitcond = icmp ne i64 %indvar, 200
+  br i1 %exitcond, label %for.inc, label %ret
+
+for.inc:                                          ; preds = %for
+  %indvar.next = add i64 %indvar, 1
+  br label %for
+
+ret:                                              ; preds = %for, %notintree
+  ret void
+}
+
+; CHECK: [0] entry => <Function Return>
+; CHECK:   [1] for => ret
+