staging: comedi: amplc_pci230: shrink struct pci230_board
authorIan Abbott <abbotti@mev.co.uk>
Mon, 1 Sep 2014 11:03:45 +0000 (12:03 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 2 Sep 2014 18:21:31 +0000 (11:21 -0700)
The `ai_bits`, `ao_bits`, and `min_hwver` members of `struct
pci230_board` are only set to small, non-negative values, so make them
`unsigned char`.  The `have_dio` member is used as a boolean so change
it to a bitfield of type `bool`.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/amplc_pci230.c

index 75b0e79117937cea392e10d283d1d9ae728b163c..7fa9c70c98a4ed50ea477b8901e512d5217017b7 100644 (file)
@@ -454,10 +454,10 @@ enum {
 struct pci230_board {
        const char *name;
        unsigned short id;
-       int ai_bits;
-       int ao_bits;
-       int have_dio;
-       unsigned int min_hwver; /* Minimum hardware version supported. */
+       unsigned char ai_bits;
+       unsigned char ao_bits;
+       unsigned char min_hwver; /* Minimum hardware version supported. */
+       bool have_dio:1;
 };
 
 static const struct pci230_board pci230_boards[] = {
@@ -466,7 +466,7 @@ static const struct pci230_board pci230_boards[] = {
                .id             = PCI_DEVICE_ID_PCI230,
                .ai_bits        = 16,
                .ao_bits        = 12,
-               .have_dio       = 1,
+               .have_dio       = true,
                .min_hwver      = 1,
        },
        {
@@ -480,7 +480,7 @@ static const struct pci230_board pci230_boards[] = {
                .id             = PCI_DEVICE_ID_PCI230,
                .ai_bits        = 12,
                .ao_bits        = 12,
-               .have_dio       = 1,
+               .have_dio       = true,
        },
        {
                .name           = "pci260",