fold debugfs_create() into caller
authorAl Viro <viro@zeniv.linux.org.uk>
Sun, 25 Jan 2015 19:17:11 +0000 (14:17 -0500)
committerAl Viro <viro@zeniv.linux.org.uk>
Sun, 25 Jan 2015 21:52:52 +0000 (16:52 -0500)
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/debugfs/inode.c

index 8d12935c87f1ba8d6260dd87a7306f92be7580c6..778c0e32eb51a4005205034b8f70a9f754a2577e 100644 (file)
@@ -84,19 +84,6 @@ static int debugfs_mknod(struct dentry *dentry,
        return 0;
 }
 
-static int debugfs_create(struct dentry *dentry, umode_t mode,
-                         void *data, const struct file_operations *fops)
-{
-       struct inode *dir = dentry->d_parent->d_inode;
-       int res;
-
-       mode = (mode & S_IALLUGO) | S_IFREG;
-       res = debugfs_mknod(dentry, mode, data, fops);
-       if (!res)
-               fsnotify_create(dir, dentry);
-       return res;
-}
-
 static inline int debugfs_positive(struct dentry *dentry)
 {
        return dentry->d_inode && !d_unhashed(dentry);
@@ -362,7 +349,9 @@ struct dentry *debugfs_create_file(const char *name, umode_t mode,
        if (IS_ERR(dentry))
                return NULL;
 
-       error = debugfs_create(dentry, mode, data, fops);
+       error = debugfs_mknod(dentry, mode, data, fops);
+       if (!error)
+               fsnotify_create(dentry->d_parent->d_inode, dentry);
        return end_creating(dentry, error);
 }
 EXPORT_SYMBOL_GPL(debugfs_create_file);