[LLC]: Restrict LLC sockets to root
authorPatrick McHardy <kaber@trash.net>
Fri, 28 Mar 2008 03:28:10 +0000 (20:28 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 28 Mar 2008 03:28:10 +0000 (20:28 -0700)
LLC currently allows users to inject raw frames, including IP packets
encapsulated in SNAP. While Linux doesn't handle IP over SNAP, other
systems do. Restrict LLC sockets to root similar to packet sockets.

[ Modified Patrick's patch to use CAP_NEW_RAW --DaveM ]

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/llc/af_llc.c

index 46cf962f7f8889f049a3b0406f9f5f3b6c31034c..8c50eb430c19514f1aa811ef77bc6a12c5f7a399 100644 (file)
@@ -155,6 +155,9 @@ static int llc_ui_create(struct net *net, struct socket *sock, int protocol)
        struct sock *sk;
        int rc = -ESOCKTNOSUPPORT;
 
+       if (!capable(CAP_NET_RAW))
+               return -EPERM;
+
        if (net != &init_net)
                return -EAFNOSUPPORT;