ASoC: ml26124: Cleanup manual bias level transitions
authorLars-Peter Clausen <lars@metafoo.de>
Sat, 6 Sep 2014 12:29:34 +0000 (14:29 +0200)
committerMark Brown <broonie@kernel.org>
Sat, 6 Sep 2014 12:38:07 +0000 (13:38 +0100)
Set the CODEC driver's suspend_bias_off flag rather than manually going to
SND_SOC_BIAS_OFF in suspend and SND_SOC_BIAS_STANDBY in resume. This makes
the code a bit shorter and cleaner.

The manual transition to SND_SOC_BIAS_STANDBY at the end of CODEC probe()
can also be removed as the core will automatically do this after the CODEC
has been probed.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/ml26124.c

index e661e8420e3dd25b95179c7413adfea8637cd9e2..711f55039522f473a5070cb1454a03132423f5d6 100644 (file)
@@ -565,41 +565,19 @@ static struct snd_soc_dai_driver ml26124_dai = {
        .symmetric_rates = 1,
 };
 
-#ifdef CONFIG_PM
-static int ml26124_suspend(struct snd_soc_codec *codec)
-{
-       ml26124_set_bias_level(codec, SND_SOC_BIAS_OFF);
-
-       return 0;
-}
-
-static int ml26124_resume(struct snd_soc_codec *codec)
-{
-       ml26124_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
-
-       return 0;
-}
-#else
-#define ml26124_suspend NULL
-#define ml26124_resume NULL
-#endif
-
 static int ml26124_probe(struct snd_soc_codec *codec)
 {
        /* Software Reset */
        snd_soc_update_bits(codec, ML26124_SW_RST, 0x01, 1);
        snd_soc_update_bits(codec, ML26124_SW_RST, 0x01, 0);
 
-       ml26124_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
-
        return 0;
 }
 
 static struct snd_soc_codec_driver soc_codec_dev_ml26124 = {
        .probe =        ml26124_probe,
-       .suspend =      ml26124_suspend,
-       .resume =       ml26124_resume,
        .set_bias_level = ml26124_set_bias_level,
+       .suspend_bias_off = true,
        .dapm_widgets = ml26124_dapm_widgets,
        .num_dapm_widgets = ARRAY_SIZE(ml26124_dapm_widgets),
        .dapm_routes = ml26124_intercon,