cciss: Fallback to MSI rather than to INTx if MSI-X failed

Currently the driver falls back to INTx mode when MSI-X
initialization failed. This is a suboptimal behaviour
for chips that also support MSI. This update changes that
behaviour and falls back to MSI mode in case MSI-X mode
initialization failed.

Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Cc: Mike Miller <mike.miller@hp.com>
Cc: iss_storagedev@hp.com
Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-pci@vger.kernel.org
Signed-off-by: Jens Axboe <axboe@fb.com>

diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index 036e8ab86c718057ae01c9f6bf3ba6c403a6b942..73894ca3395662c80178a110ca53823454f857f4 100644 (file)
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -4092,11 +4092,9 @@ static void cciss_interrupt_mode(ctlr_info_t *h)
                if (err > 0) {
                        dev_warn(&h->pdev->dev,
                                "only %d MSI-X vectors available\n", err);
-                       goto default_int_mode;
                } else {
                        dev_warn(&h->pdev->dev,
                                "MSI-X init failed %d\n", err);
-                       goto default_int_mode;
                }
        }
        if (pci_find_capability(h->pdev, PCI_CAP_ID_MSI)) {