[ARM] S3C24XX: GPIO: Fix error returns from gpio functions

Several GPIO functions have been returning -1 to indicate
an error instead of returning a proper error code. Change
to return -EINVAL for invalid argument(s).

Signed-off-by: Ben Dooks <ben-linux@fluff.org>

diff --git a/arch/arm/mach-s3c2400/gpio.c b/arch/arm/mach-s3c2400/gpio.c
index 81ebe2f09901761bbf5543e0b82a6caf32439e49..6c68e78f359579055b60ef63140eb63d322d4114 100644 (file)
--- a/arch/arm/mach-s3c2400/gpio.c
+++ b/arch/arm/mach-s3c2400/gpio.c
@@ -33,8 +33,8 @@
 
 int s3c2400_gpio_getirq(unsigned int pin)
 {
-       if (pin < S3C2410_GPE(0) || pin > S3C2400_GPE7_EINT7)
-               return -1;  /* not valid interrupts */
+       if (pin < S3C2410_GPE(0) || pin > S3C2400_GPE(7))
+               return -EINVAL;  /* not valid interrupts */
 
        return (pin - S3C2410_GPE(0)) + IRQ_EINT0;
 }

diff --git a/arch/arm/mach-s3c2410/gpio.c b/arch/arm/mach-s3c2410/gpio.c
index bf7fbfe7e4d8ab330ac7298dd48b53d49a78e54b..7974afca297ce2282a276ed51063b5d28e3e738e 100644 (file)
--- a/arch/arm/mach-s3c2410/gpio.c
+++ b/arch/arm/mach-s3c2410/gpio.c
@@ -40,7 +40,7 @@ int s3c2410_gpio_irqfilter(unsigned int pin, unsigned int on,
        unsigned long val;
 
        if (pin < S3C2410_GPG(8) || pin > S3C2410_GPG(15))
-               return -1;
+               return -EINVAL;
 
        config &= 0xff;
 

diff --git a/arch/arm/plat-s3c24xx/gpio.c b/arch/arm/plat-s3c24xx/gpio.c
index ae0b9d6f3fb8c93021b263ab47398e0fa93345f3..95df059b5a1db2b7430ee52972b83034e6b3f6de 100644 (file)
--- a/arch/arm/plat-s3c24xx/gpio.c
+++ b/arch/arm/plat-s3c24xx/gpio.c
@@ -184,10 +184,10 @@ EXPORT_SYMBOL(s3c2410_modify_misccr);
 int s3c2410_gpio_getirq(unsigned int pin)
 {
        if (pin < S3C2410_GPF(0) || pin > S3C2410_GPG(15))
-               return -1;      /* not valid interrupts */
+               return -EINVAL; /* not valid interrupts */
 
        if (pin < S3C2410_GPG(0) && pin > S3C2410_GPF(7))
-               return -1;      /* not valid pin */
+               return -EINVAL; /* not valid pin */
 
        if (pin < S3C2410_GPF(4))
                return (pin - S3C2410_GPF(0)) + IRQ_EINT0;