ARM64: make sure first argument to INSERT_SUBVECTOR has right type.
authorTim Northover <tnorthover@apple.com>
Wed, 2 Apr 2014 14:38:58 +0000 (14:38 +0000)
committerTim Northover <tnorthover@apple.com>
Wed, 2 Apr 2014 14:38:58 +0000 (14:38 +0000)
Again, coalescing and other optimisations swiftly made the MachineInstrs
consistent again, but when compiled at -O0 a bad INSERT_SUBREGISTER was
produced.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@205423 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Target/ARM64/ARM64ISelLowering.cpp
test/CodeGen/ARM64/simd-scalar-to-vector.ll

index b6672ee0d7f3bcb5af4b62df3c4b5b868d71ae02..66207790c8a1156b0aef30357c6f8c29e9c83950 100644 (file)
@@ -5615,7 +5615,7 @@ SDValue ARM64TargetLowering::LowerSCALAR_TO_VECTOR(SDValue Op,
   }
   MachineSDNode *N =
       DAG.getMachineNode(TargetOpcode::INSERT_SUBREG, SDLoc(Op),
-                         Op.getValueType(), DAG.getUNDEF(Op0.getValueType()),
+                         Op.getValueType(), DAG.getUNDEF(Op.getValueType()),
                          Op0, DAG.getTargetConstant(SubIdx, MVT::i32));
   return SDValue(N, 0);
 }
index fe0c6fedddb0c90a9c9dec54f7dd7ea5e8e3d33b..6c0b840a5c10b6a973f0b2c6f632acd41d277173 100644 (file)
@@ -1,10 +1,15 @@
 ; RUN: llc < %s -march=arm64 -arm64-neon-syntax=apple | FileCheck %s
+; RUN: llc < %s -march=arm64 -arm64-neon-syntax=apple -O0 | FileCheck %s --check-prefix=CHECK-FAST
 
 define <16 x i8> @foo(<16 x i8> %a) nounwind optsize readnone ssp {
-; CHECK: uaddlv.16b    h0, v0
-; CHECK: rshrn.8b      v0, v0, #4
-; CHECK: dup.16b       v0, v0[0]
+; CHECK: uaddlv.16b h0, v0
+; CHECK: rshrn.8b v0, v0, #4
+; CHECK: dup.16b v0, v0[0]
 ; CHECK: ret
+
+; CHECK-FAST: uaddlv.16b
+; CHECK-FAST: rshrn.8b
+; CHECK-FAST: dup.16b
   %tmp = tail call i32 @llvm.arm64.neon.uaddlv.i32.v16i8(<16 x i8> %a) nounwind
   %tmp1 = trunc i32 %tmp to i16
   %tmp2 = insertelement <8 x i16> undef, i16 %tmp1, i32 0