ixgbe: Return success or failure on VF MAC filter set
authorGreg Rose <gregory.v.rose@intel.com>
Tue, 25 Sep 2012 02:25:30 +0000 (02:25 +0000)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Tue, 30 Oct 2012 05:32:07 +0000 (22:32 -0700)
When setting a MAC filter for the VF the function should return a success
or failure code, not the index of the new filter.  It causes spurious NACK
returns to the VF driver.

Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Tested-by: Sibai Li <sibai.li@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c

index 8bdb341c14bf7fb025a29636aeecc6b36211c6bf..bfeb7ec2abd9102ed1e991d4a71c01a68800a04b 100644 (file)
@@ -675,7 +675,7 @@ static int ixgbe_set_vf_mac_addr(struct ixgbe_adapter *adapter,
                return -1;
        }
 
-       return ixgbe_set_vf_mac(adapter, vf, new_mac);
+       return ixgbe_set_vf_mac(adapter, vf, new_mac) < 0;
 }
 
 static int ixgbe_set_vf_vlan_msg(struct ixgbe_adapter *adapter,