usb: chipidea: don't clobber return value of ci_role_start()
authorLothar Waßmann <LW@KARO-electronics.de>
Wed, 14 Aug 2013 09:44:00 +0000 (12:44 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Aug 2013 19:34:16 +0000 (12:34 -0700)
If a role fails to start, propagate the error code up the call stack
from probe.

Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/chipidea/core.c

index a5b3774bb223d84f69c9bd6d145d00858152e009..2400b7f87f978739e45db6d4a790d82360620903 100644 (file)
@@ -497,7 +497,6 @@ static int ci_hdrc_probe(struct platform_device *pdev)
        ret = ci_role_start(ci, ci->role);
        if (ret) {
                dev_err(dev, "can't start %s role\n", ci_role(ci)->name);
-               ret = -ENODEV;
                goto rm_wq;
        }