scripts/get_maintainer.pl: fix possible infinite loop
authorJoe Perches <joe@perches.com>
Fri, 5 Mar 2010 21:43:07 +0000 (13:43 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 6 Mar 2010 19:26:34 +0000 (11:26 -0800)
If MAINTAINERS section entries are misformatted, it was possible to have
an infinite loop.

Correct the defect by always moving the index to the end of section + 1

Also, exit check for exclude as soon as possible.

Signed-off-by: Joe Perches <joe@perches.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
scripts/get_maintainer.pl

index b61002dceaba7ac2e665a5c39ff1fb2a2ec11d6f..f76f3d13276dd114c880e13ec45cad7452f992b9 100755 (executable)
@@ -347,6 +347,7 @@ foreach my $file (@files) {
                if ($type eq 'X') {
                    if (file_match_pattern($file, $value)) {
                        $exclude = 1;
+                       last;
                    }
                }
            }
@@ -373,8 +374,7 @@ foreach my $file (@files) {
            }
        }
 
-       $tvi += ($end - $start);
-
+       $tvi = $end + 1;
     }
 
     foreach my $line (sort {$hash{$b} <=> $hash{$a}} keys %hash) {