remoteproc: remove redundant NULL check before release_firmware()
authorJesper Juhl <jj@chaosbits.net>
Mon, 9 Apr 2012 20:51:25 +0000 (22:51 +0200)
committerJiri Kosina <jkosina@suse.cz>
Mon, 30 Apr 2012 11:24:45 +0000 (13:24 +0200)
release_firmware deals gracefully with NULL pointers, so checking
first is redundant.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/remoteproc/remoteproc_core.c

index ee15c68fb5192cfb03ac9cb2207be17bbc17abc0..3d2884b0a4fcdc7cb3f600a7e15eee13720b5544 100644 (file)
@@ -1105,8 +1105,7 @@ static void rproc_fw_config_virtio(const struct firmware *fw, void *context)
                goto out;
 
 out:
-       if (fw)
-               release_firmware(fw);
+       release_firmware(fw);
        /* allow rproc_unregister() contexts, if any, to proceed */
        complete_all(&rproc->firmware_loading_complete);
 }