KVM: s390: Fix possible memory leak of in kvm_arch_vcpu_create()
authorWei Yongjun <yjwei@cn.fujitsu.com>
Tue, 9 Mar 2010 06:37:53 +0000 (14:37 +0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 5 Jul 2010 18:11:16 +0000 (11:11 -0700)
This patch fixed possible memory leak in kvm_arch_vcpu_create()
under s390, which would happen when kvm_arch_vcpu_create() fails.

Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Acked-by: Carsten Otte <cotte@de.ibm.com>
Cc: stable@kernel.org
Signed-off-by: Avi Kivity <avi@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
(cherry picked from commit 7b06bf2ffa15e119c7439ed0b024d44f66d7b605)

arch/s390/kvm/kvm-s390.c

index ca2d31277b3b46eee836d1c34403521377732692..75fbf199d71ec79cc2d9b5e61a66232b305bd3d9 100644 (file)
@@ -338,11 +338,13 @@ struct kvm_vcpu *kvm_arch_vcpu_create(struct kvm *kvm,
 
        rc = kvm_vcpu_init(vcpu, kvm, id);
        if (rc)
-               goto out_free_cpu;
+               goto out_free_sie_block;
        VM_EVENT(kvm, 3, "create cpu %d at %p, sie block at %p", id, vcpu,
                 vcpu->arch.sie_block);
 
        return vcpu;
+out_free_sie_block:
+       free_page((unsigned long)(vcpu->arch.sie_block));
 out_free_cpu:
        kfree(vcpu);
 out_nomem: