staging: comedi: mf6x4: remove unnecassary masking of digital outputs
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Tue, 6 Oct 2015 18:11:12 +0000 (11:11 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 13 Oct 2015 05:55:31 +0000 (22:55 -0700)
THe 's->state' will always be in range for the 8 digital outputs.
Remove the unnecessary masking of the value.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
 drivers/staging/comedi/drivers/mf6x4.c | 6 +++---
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/mf6x4.c

index 1e4f08058723e89f3086ed1aef59b96110f4dc49..03f81e948b95703e954ff2f76a520f1e233c66e3 100644 (file)
@@ -43,8 +43,7 @@
 #define MF6X4_ADCTRL_CHAN(x)   BIT(chan)
 #define MF6X4_DIN_R            0x10
 #define MF6X4_DIN_M            0xff
-#define MF6X4_DOUT_R           0x10
-#define MF6X4_DOUT_M           0xff
+#define MF6X4_DOUT_REG         0x10
 #define MF6X4_ADSTART_R                0x20
 #define MF6X4_DAC_R(x)         (0x20 + ((x) * 2))
 
@@ -107,7 +106,7 @@ static int mf6x4_do_insn_bits(struct comedi_device *dev,
                              unsigned int *data)
 {
        if (comedi_dio_update_state(s, data))
-               iowrite16(s->state & MF6X4_DOUT_M, dev->mmio + MF6X4_DOUT_R);
+               iowrite16(s->state, dev->mmio + MF6X4_DOUT_REG);
 
        data[1] = s->state;