regulator: wm831x-dcdc: set_current_limit should select the maximum current in specif...
authorAxel Lin <axel.lin@gmail.com>
Wed, 8 Aug 2012 12:20:29 +0000 (20:20 +0800)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Tue, 28 Aug 2012 18:00:26 +0000 (11:00 -0700)
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
drivers/regulator/wm831x-dcdc.c

index 7413885be01ba5907117c4c95d89df1a4129924b..90cbcc683704b748c032653f5827e2704b95e8f2 100644 (file)
@@ -339,16 +339,15 @@ static int wm831x_buckv_set_current_limit(struct regulator_dev *rdev,
        u16 reg = dcdc->base + WM831X_DCDC_CONTROL_2;
        int i;
 
-       for (i = 0; i < ARRAY_SIZE(wm831x_dcdc_ilim); i++) {
+       for (i = ARRAY_SIZE(wm831x_dcdc_ilim) - 1; i >= 0; i--) {
                if ((min_uA <= wm831x_dcdc_ilim[i]) &&
                    (wm831x_dcdc_ilim[i] <= max_uA))
-                       break;
+                       return wm831x_set_bits(wm831x, reg,
+                                              WM831X_DC1_HC_THR_MASK,
+                                               i << WM831X_DC1_HC_THR_SHIFT);
        }
-       if (i == ARRAY_SIZE(wm831x_dcdc_ilim))
-               return -EINVAL;
 
-       return wm831x_set_bits(wm831x, reg, WM831X_DC1_HC_THR_MASK,
-                              i << WM831X_DC1_HC_THR_SHIFT);
+       return -EINVAL;
 }
 
 static int wm831x_buckv_get_current_limit(struct regulator_dev *rdev)